是否有更好的語法來執行此代碼？

Question

下面是我的代碼

if(!chineseName) { 
     alert("chineseName is not correct"); 
    } 
    else if(!IDN){ 
     alert("IDN is not correct"); 
    } 
    else if(!mobileNumber){ 
     alert("number is not correct"); 
    } 
    else if(hasAccount){ 
     if(!isAccountNumberValid) { 
      alert("account number is not correct"); 
     } 
     else { 
      check(); 
     } 
    } 
    else { 
     check(); 
    } 



    function check() { 
     if(!check1 && !check2) { 
      alert("Please read NOTE and check the read box."); 
     } 
     else { 
      alert("Everything is good to go!!"); 
     } 
    } 

現在，這個代碼工作正確。 但是，我想知道是否有更好的語法來執行相同的事情？

謝謝。

Answer 1

您可以組合最後兩個，因爲動作是相同的，只需更改最後一個條件即可。

if (!chineseName) { 
    alert("chineseName is not correct"); 
} else if (!IDN){ 
    alert("IDN is not correct"); 
} else if (!mobileNumber){ 
    alert("number is not correct"); 
} else if (hasAccount && !isAccountNumberValid) { // Modified condition 
    alert("account number is not correct"); 
} else { 
    check(); 
} 

Answer 2

你或許可以將所有警報到一個：

var msg = ""; 

if (!chineseName) { 
    msg = "chineseName is not correct"; 
} else if (!IDN) { 
    msg = "IDN is not correct"; 
} else if (!mobileNumber) { 
    msg = "number is not correct"; 
} else if (hasAccount) { 
    if (!isAccountNumberValid) { 
     msg = "account number is not correct"; 
    } else { 
     msg = check(); 
    } 
} else { 
    msg = check(); 
} 

alert(msg); 


function check() { 
    if (!check1 && !check2) 
     return "Please read NOTE and check the read box."; 

    return "Everything is good to go!!"; 
}