PHP - 使代碼更高效/專業

Question

我正在從事一項PHP任務，基本上我做的一切都很好。然而，由於我對PHP的知識有限，代碼看起來有些過於簡單。它所做的是根據輸入的小時數和工資計算總工資。

有你們可以提供，使之更好/更短和更有效的有什麼建議？

<?php 
$hours = $_GET ["hours"]; 
$wages = $_GET ["wages"]; 

if (empty($hours)) 
{ 
    echo "Amount of hours worked is required. <br />"; 
} 
if (empty($wages)) 
{ 
    echo "Employee wage is required. <br />"; 
} 

if (!is_numeric($hours) and ($wages) && !empty ($hours) and ($wages)) 
{ 
    echo "Please enter numeric numbers only. <br />"; 
} 

if (!empty($hours) and ($wages)) 
{ 
    if (is_numeric($hours) and ($wages)) 
    { 
     if ($hours <= 40) 
     { 
     $totalPay = $hours * $wages; 
     echo "Your total pay is $ $totalPay"; 
     } 

     if ($hours > 40) 
     { 
     $totalPay = ((40 * $wages) + (($hours - 40) * $wages * 1.5)); 
     echo "Your total pay is $ $totalPay"; 
     } 
    } 
}  
else 
{ 
    echo "Unable to calculate total pay."; 
} 

？>

Answer 1

你可以把它甚至通過實施validate功能

function validate($time, $fee) 
{ 
    if(!is_numeric($time) || empty($time)) // ...etc 
    { 
     return false; 
    } 

    return true; 
} 

if(validate($_GET['hours'], $_GET['wages'])) 
{ 
    // do your calculation 
} 
else 
{ 
    // display error 
}