（已關閉）Conway的生命遊戲未正確更新（Python）

Question

這是使用Python製作的Conway的Game of Life模擬代碼片段。這對於檢查它是否可行是非常簡單的 - 事實並非如此。不知道爲什麼，但據我所知，這是更新的東西。

希望任何輸入，爲什麼它更新它的方式：

GIF圖片pygame的（相同的代碼）： http://imgur.com/6US3Nje 不更新正確： http://imgur.com/9gubzAF

import pprint,random 
#here we make the initial board, 6x6 
board = [] 
for y in range (6): 
    row = [] 
    for x in range (6): 
     row.append(random.randint(0,1)) 
    board.append(row) 
#and display it 
pprint.pprint(board) 

#this function counts the neighbours for each cell 
def neighbours(x,y): 
    counter = 0 
    neighbours = \ 
    [(x-1,y+1),(x,y+1),(x+1,y+1),\ 
    (x-1,y),   (x+1,y),\ 
    (x-1,y-1),(x,y-1),(x+1,y-1)] 
    for n in neighbours: 
     a, b = n 
     try: 
      counter += board[a][b] 
     except: 
      pass 
#printed out the counter to check if it counted correctly (it does, as far as I could tell) 
    if x == 4 and y == 4: 
     print(counter) 
    return counter 

#function to make a new board based off the old one - basically, the updater. 
#here's where the problem might lie - but for the life of me I cannot tell where and why. 
def new(board): 
    new_board = [] 
    for y in range(6): 
     new_row = [] 
     for x in range(6): 
      n = neighbours(x,y) 
      oldcell = board[x][y] 
      #everything is set up to be according to the rules 
      #(if dead(0) can only come alive with 3 alive cells 
      #(if alive(1) can continue to live with exactly 2 or 3 live neighbours 
      if oldcell == 0: 
       newcell = 0 
       if n == 3: 
        newcell = 1 
      elif oldcell == 1: 
       newcell = 1 
       if n > 3 or n < 2: 
        newcell = 0 
      new_row.append(newcell) 
     new_board.append(new_row) 
    return new_board 

#displaying the board for 6 instances 
for i in range (6): 
    nboard = new(board) 
    board = nboard 
    pprint.pprint(board) 

提前感謝！

Answer 1

您正在混合循環中的行和列，將每個新電路板的整個矩陣有效地轉置。該循環應該是這樣的：

for x in range(6): 
    new_row = [] 
    for y in range(6): 
     ... 

此外，您if/else邏輯循環中的大部分可以簡化爲一條直線。這是否容易閱讀和理解是由你來決定的。

def new(board): 
    new_board = [] 
    for x in range(6): 
     new_row = [] 
     for y in range(6): 
      n = neighbours(x,y) 
      oldcell = board[x][y] 
      newcell = int(n in (2, 3)) if oldcell else int(n == 3) 
      new_row.append(newcell) 
     new_board.append(new_row) 
    return new_board 

---

如前所述in comments，有一個第二（儘管不太明顯）的問題：當你try/except跳過所有場外指數是一個不錯的主意，它並不如趕上x-1對於x = 0，因爲[-1]是Python中的一個合法索引（索引序列中的最後一個元素），使您的電路板「環繞」四個邊中的兩個。相反，你應該明確檢查板子的邊界。如果你願意，你可以把這個另一種「樂趣」的一行：

def neighbours(x,y): 
    return sum(board[a][b] for a in (x-1,x,x+1) for b in (y-1,y,y+1) 
       if (a,b) != (x,y) and 0 <= a < len(board) and 0 <= b < len(board[a])) 

當然，你也可以讓你的循環，只需更換try/except爲if檢查。